Limit pod resources #237
Limit pod resources #237
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lpiwowar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d1f08eda674d4d749df5a6f8ee9b5ad1 ❌ openstack-k8s-operators-content-provider FAILURE in 6m 09s |
This patch introduces back limits for the pods spawned by the
test-operator after they were increased and later removed with these
two PRs [1][2].
The problem with the previous two patches was that they only set the
Resources.Limits field and not the Resources.Requests field. When
Resources.Limits is set and Resources.Requests is empty then it
inherrits the value from Resources.Limits.
Therefore, we first hit the OOM killed issue when we set the
Resources.Limits too low and later when we increased the value we hit
the "Insufficient memory" error (due to high value in
Resources.Requests field)
This patch addresses the above mentioned issue by:
- setting sane default values for Resource.Limits
- setting sane default values for Resource.Requests and
- introduces new parameter called .Spec.Resources which can be used
to change the default values.
[1] openstack-k8s-operators#222
[2] openstack-k8s-operators#224
lpiwowar
force-pushed
the
feature/resource-limits
branch
from
03aa100
to
1f7805e
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3ac9e170c7f044dca35650459699e731 ❌ openstack-k8s-operators-content-provider FAILURE in 7m 44s |
This patch introduces back limits for the pods spawned by the
test-operator after they were increased and later removed with these
two PRs [1][2].
The problem with the previous two patches was that they only set the
Resources.Limits field and not the Resources.Requests field. When
Resources.Limits is set and Resources.Requests is empty then it
inherrits the value from Resources.Limits.
Therefore, we first hit the OOM killed issue when we set the
Resources.Limits too low and later when we increased the value we hit
the "Insufficient memory" error (due to high value in
Resources.Requests field)
This patch addresses the above mentioned issue by:
to change the default values.
[1] #222
[2] #224