Remove TempestRegexp argument #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like it was not in use since the begning. Users usually finds simpler to have explicit negative list, even tough it is possible to consutuct a singe regexp. Also possible to construct a single regexp on the operator side, in case other way of passing would be prefered later on. Moving the default allowedTests to the defaults. Note: Consider moving the tempest run arguments to sub structure.
!backward incomatible! Moving the tempest run related args to their own section. Adding concurrency related args.
|
Added a second commit, |
|
lgtm, tested and it all still works .. we can add --regex and --smoke support in a new commit |
|
/lgtm |
|
it seems there is no bot? meh, i'll click the merge pull request button :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like it was not in use since the begning.
Users usually finds simpler to have explicit negative list,
even tough it is possible to consutuct a singe regexp.
Also possible to construct a single regexp on the operator side,
in case other way of passing would be prefered later on.
Moving the default allowedTests to the defaults.
Note: Consider moving the tempest run arguments
to sub structure.