Ticket-105 #383
Ticket-105 #383
Conversation
…ts because the file i was working on had additional codes added, took all teh feedback & fixed it
…ts because the file i was working on had additional codes added, took all teh feedback & fixed it
|
Does this mean we should close #378 ? Let me know - we should try to clean this up cause it's a little confusing seeing two PRs for the same issue |
|
The New Tag should be removed from studies and introducted to the learning path. |
|
@divitcr7 can you update the pull request title and description to give a more accurate depiction of what this pull request is doing? thanks! |
|
For the color to appear for filled icons, it needs to be styled using the color tag inside the style prop, instead of the color prop. The Button Tag can be removed and the Icon can directly handle the onClick event. |
There may be an issue with the navigation bar on other pages, as the padding between the highlighted line and the navbar is small. Also, it can be furthur simplied by using border-bottom instead of :after
Resolved |
| /> | ||
| ) | ||
| } | ||
|
|
||
| export const StudiesTitle: FC<{search: string, filteredStudies: ParticipantStudy[]}> = () => { | ||
| return ( | ||
| <Title order={2} id='all-studies-unique-id'>All Studies</Title> | ||
| <Title order={2} id='all-studies-unique-id' style={{ paddingLeft: '2.5rem',paddingRight: '2.5rem' }}>View All Studies</Title> |
There was a problem hiding this comment.
I think we can probably merge this since Iris is eagerly awaiting these changes. There are some things we should come back to in terms of cleaning up inline styles, using mantine props where possible (instead of writing our own CSS) and being consistent about trying to use mantine's sizes (ie xs, sm, md, lg, xl) instead of hardcoding X.Y rem units
Switched to a new branch had issues because the file i was working on had additional codes added to main & that led to merge conflicts, took all the feedback in & fixed it