Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reng 111 -> (Learner - Achievements Banner) #389

Merged
merged 27 commits into from
Sep 9, 2024
Merged

Reng 111 -> (Learner - Achievements Banner) #389

merged 27 commits into from
Sep 9, 2024

Conversation

divitcr7
Copy link
Contributor

@divitcr7 divitcr7 commented Aug 5, 2024

introducing a new component to the dashboard view allowing students to quickly see their progress in studies completed, points earned and badges unlocked.

@chrisbendel
Copy link
Collaborator

@divitcr7 would you mind updating the PR title and the description to describe what this PR is doing?

@divitcr7
Copy link
Contributor Author

divitcr7 commented Aug 5, 2024

GIVEN the user visits OS Kinetic after having completed at least 1 study

WHEN they land on the studies page dashboard

THEN they must see their progress programmatically represented in each respective section

image

@divitcr7 divitcr7 changed the title Reng 111 Reng 111 -> (Learner - Achievements Banner) Aug 8, 2024
@chrisbendel
Copy link
Collaborator

@divitcr7 the point of the comments around the inline styles weren't to extract them out and continue using the style prop, it was to utilize the mantine components and their properties to set the styles so the look and feel of the site is consistent - we want to minimize as much "one off" CSS properties as possible if that makes sense

@divitcr7
Copy link
Contributor Author

It's tested we can push it

gap={0}
justify={hasValue ? 'center' : 'start'}
align={hasValue ? 'center' : 'start'}
miw={'12.5rem'}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we want to avoid these types of values remember?

Copy link
Contributor

@Coder-Srinivas Coder-Srinivas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaned up the code. @chrisbendel let me know if any changes are required.

@chrisbendel
Copy link
Collaborator

Looks good @Coder-Srinivas

let me know when you want me to deploy to staging too 👍

@Coder-Srinivas Coder-Srinivas merged commit bdaf21b into main Sep 9, 2024
4 checks passed
@Coder-Srinivas Coder-Srinivas deleted the RENG-111 branch September 9, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants