-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reng 111 -> (Learner - Achievements Banner) #389
Conversation
@divitcr7 would you mind updating the PR title and the description to describe what this PR is doing? |
…is failing in github studyBanner.tsx
@divitcr7 the point of the comments around the inline styles weren't to extract them out and continue using the |
It's tested we can push it |
frontend/src/screens/studyBanner.tsx
Outdated
gap={0} | ||
justify={hasValue ? 'center' : 'start'} | ||
align={hasValue ? 'center' : 'start'} | ||
miw={'12.5rem'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we want to avoid these types of values remember?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleaned up the code. @chrisbendel let me know if any changes are required.
Looks good @Coder-Srinivas let me know when you want me to deploy to staging too 👍 |
introducing a new component to the dashboard view allowing students to quickly see their progress in studies completed, points earned and badges unlocked.