Added user notifications #401
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Coder-Srinivas
commented
Jan 13, 2025
Coder-Srinivas
commented
- Send a welcome mail to users when they finish their first study
- Send an email to users when a new study becomes available
- Send an email to users when a new learning path becomes available
- Send an email to inactive users, (when they are inactive for more than 60 days and an email hasn't been sent already)
chrisbendel
reviewed
Jan 16, 2025
| @@ -5,6 +5,9 @@ class Api::V1::Participant::StudiesController < Api::V1::BaseController | |||
| before_action :set_study, only: [:launch, :land, :stats] | |||
|
|
|||
| def index | |||
| current_user_preference = UserPreferences.find_or_initialize_by(user_id: current_user.id) | |||
| current_user_preference.update!(last_visited_at: Time.current, nurturing_email_sent: false) | |||
There was a problem hiding this comment.
do we want to reset the nurturing_email_sent every time they load the studies page? just checking :)
chrisbendel
reviewed
Jan 16, 2025
| @@ -37,7 +37,9 @@ def deliver_new_studies | |||
| return unless users.any? | |||
|
|
|||
| users.each_value do |user| | |||
| UserMailer.with(user:, studies:).new_studies.deliver | |||
| studies.each do |study| | |||
There was a problem hiding this comment.
with looping over each study, would we be emailing user A for every new study? ie would they get 5 emails if there were 5 new studies? is that what we want?
chrisbendel
reviewed
Jan 16, 2025
|
|
||
| selected_learning_path = LearningPath | ||
| .where.not(id: initiated_learning_path_ids) | ||
| .order('RANDOM()') |
There was a problem hiding this comment.
just curious about this RANDOM() here 😄
chrisbendel
reviewed
Jan 16, 2025
Comment on lines
+36
to
+40
| user_info = UserInfo.for_uuid(user_id) | ||
| recipient = Struct.new(:email_address, :full_name).new( | ||
| user_info['email_address'] || '[email protected]', | ||
| user_info[:full_name] | ||
| ) |
There was a problem hiding this comment.
Technically this can be moved below the return unless since we don't use it if that condition is met 🤔 not a big deal at all though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.