fix crash when creating initials for user without first and last name #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
that's a tough one. my only other ideas are |
bethshook
approved these changes
Oct 23, 2024
|
A question mark would be unambiguous. |
RoyEJohnson
approved these changes
Oct 24, 2024
|
if you made them spaces it would show an empty circle, i feel like even that would be less confusing than |
jivey
force-pushed
the
fix-first-last-initial
branch
from
352b35b
to
90e9e7f
Compare
jivey
commented
Nov 4, 2024
| display: block; | ||
| width: auto; | ||
| height: 3.5rem; | ||
| } |
There was a problem hiding this comment.
Something with the snapshots is duplicating styles, there's multiple copies of the same rules in this spec...
TomWoodward
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openstax.atlassian.net/browse/CORE-587
Assignable students do not have first and last names associated, so REX crashes trying to make initials for the dropdown menu. Suggestions for alternatives to "AU" (Anonymous User? Assignable User?) are welcome.