-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update eslint settings and fix errors #2383
Open
RoyEJohnson
wants to merge
4
commits into
main
Choose a base branch
from
use-eslint-react-plugins
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyEJohnson
force-pushed
the
use-eslint-react-plugins
branch
from
January 8, 2025 17:55
279b7a4
to
c39d22b
Compare
RoyEJohnson
force-pushed
the
use-eslint-react-plugins
branch
from
January 8, 2025 18:09
c39d22b
to
18f34b0
Compare
RoyEJohnson
force-pushed
the
use-eslint-react-plugins
branch
from
January 8, 2025 18:11
18f34b0
to
3a56da8
Compare
RoyEJohnson
force-pushed
the
use-eslint-react-plugins
branch
from
January 8, 2025 19:34
3a56da8
to
9fe5034
Compare
RoyEJohnson
force-pushed
the
use-eslint-react-plugins
branch
from
January 8, 2025 20:46
290eb07
to
8926ad7
Compare
TomWoodward
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine to me as long as the types are all still working right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORE-674
In addition to fixing uses of
any
, there were a few non-null assertions that I changed to casts. If that seems pointless, I could disable the rule and change the casts back to assertions.