-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - Screen Recording using 'screenrecord' feature from adb #1078
base: master
Are you sure you want to change the base?
Conversation
})) | ||
|
||
it('should ...', inject(function() { | ||
expect(1).toEqual(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like autogenerated test stub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i just copy it from screenshots folder, yeah looks like it's auto generated file, i just thought it's kind of reminder to create a test, should i delete it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, of course it is better to write a proper test if it is possible.
Just a thought, since adb screenrecord has 3min limit, can't we use webrtc(mediarecorder) and record the screen displayed on device control page and show it to the user. |
it would works as scrcpy does, indeed it could work around the 3min limit. |
scrcpy use ffmpeg to record right? cmiiw |
Hello, I'm trying to add a new feature to record screen, need feedback about this feature, maybe you guys already thought about it and choose to not implement it with a good reason that I don't know
Screenrecord only able to record up to 3 minutes
need to be implemented later