Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Easy Installer (shellscipt) for Mac and Linux #1242

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gchoudhary-vmware
Copy link

Easy installation of STF, with this PR for both Mac & Linux.

now by running ./stf.sh there will be multiple options one can proceed with.

Screenshot 2020-06-18 at 9 16 29 AM

#


# Ubuntu Run Provider Unit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ubuntu is here in script for MacOS?

# Mac Master Installer inside stf folder
sudo npm install gulp-cli -g
npm install
sudo npm link # --unsafe-perm=true --allow-roots
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment text should be either removed or uncommented

# SPDX-License-Identifier:Apache2.0
#

# ./Setup/Ubuntu/Install.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed


#Set Vars
export ANDROID_SDK="$HOME/android-sdk-linux"
PATH=$PATH:$ANDROID_SDK/platform-tools;$ANDROID_SDK/tools
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

; -> :

sudo apt-get update
sudo apt-get install -y oracle-java7-installer

#adb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not adb

@gchoudhary-vmware gchoudhary-vmware marked this pull request as draft June 22, 2020 03:40
@gchoudhary-vmware
Copy link
Author

Thanks, Fixed the changes in 2nd commit.

Copy link
Member

@koral-- koral-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gchoudhary-vmware gchoudhary-vmware marked this pull request as ready for review June 29, 2020 02:44
@gchoudhary-vmware
Copy link
Author

Koral, by mistake it was on draft, now its open, you can go ahead, Thanks.

@koral--
Copy link
Member

koral-- commented Jul 13, 2020

@gchoudhary-vmware could you resumbit your PR to https://github.com/DeviceFarmer/stf?
This repository will be archived and won't be updated.
Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants