-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Easy Installer (shellscipt) for Mac and Linux #1242
base: master
Are you sure you want to change the base?
Added Easy Installer (shellscipt) for Mac and Linux #1242
Conversation
Setup/Mac/Provider.sh
Outdated
# | ||
|
||
|
||
# Ubuntu Run Provider Unit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why ubuntu is here in script for MacOS?
Setup/Mac/Master.sh
Outdated
# Mac Master Installer inside stf folder | ||
sudo npm install gulp-cli -g | ||
npm install | ||
sudo npm link # --unsafe-perm=true --allow-roots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment text should be either removed or uncommented
Setup/Ubuntu/Install.sh
Outdated
# SPDX-License-Identifier:Apache2.0 | ||
# | ||
|
||
# ./Setup/Ubuntu/Install.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed
Setup/Ubuntu/Install.sh
Outdated
|
||
#Set Vars | ||
export ANDROID_SDK="$HOME/android-sdk-linux" | ||
PATH=$PATH:$ANDROID_SDK/platform-tools;$ANDROID_SDK/tools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
; -> :
sudo apt-get update | ||
sudo apt-get install -y oracle-java7-installer | ||
|
||
#adb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not adb
f0edaf3
to
b9d51da
Compare
Thanks, Fixed the changes in 2nd commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Koral, by mistake it was on draft, now its open, you can go ahead, Thanks. |
@gchoudhary-vmware could you resumbit your PR to https://github.com/DeviceFarmer/stf? |
Easy installation of STF, with this PR for both Mac & Linux.
now by running
./stf.sh
there will be multiple options one can proceed with.