Resourceful routes for users api #5433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonKhorev
added
refactor
tomhughes
reviewed
Dec 22, 2024
There was a problem hiding this comment.
This mostly looks fine. I think the only thing I'm not sure about is moving user#details into a separate controller - it's basically an alias for user#show so does it make any sense to separate it?
That said @gravitystorm has a better grasp than me of what is the canonical rails to do these things so I'd be interest to here what he thinks.
AntonKhorev
force-pushed
the
user-routes-api-namespace
branch
from
cf784a8 to
971fbc2
Compare
|
Let's keep |
|
Looks good to me. Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves
user/detailsanduser/gpx_filesto their own controllers.