Add option to override Firefox binary used in system tests #5672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhughes
reviewed
Feb 15, 2025
config/settings.yml
Outdated
| @@ -182,3 +182,5 @@ smtp_password: null | |||
| # -----BEGIN PRIVATE KEY----- | |||
| # ... | |||
| # -----END PRIVATE KEY----- | |||
| # Override Firefox binary used in system tests | |||
| #system_test_firefox_binary: | |||
There was a problem hiding this comment.
Can we put this in config/settings/test.yml as it's only for testing?
There was a problem hiding this comment.
Is teaspoon supposed to be run in test environment?
There was a problem hiding this comment.
That's actually an excellent question - my answer would be yes, and it doesn't work in my dev environment unless I force it to, but currently there is nothing to make that happen by default.
There was a problem hiding this comment.
Actually the github workflow does run it with RAILS_ENV=test set.
There was a problem hiding this comment.
Moved to config/settings/test.yml.
Then we have to update CONTRIBUTING.md to explain how to run teaspoon.
AntonKhorev
force-pushed
the
system-test-config-binary
branch
from
20c7c02 to
b58a702
Compare
|
Thanks, this looks good to me now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5488 by providing a setting instead of workarounds such as modifying
test/application_system_test_case.rb.I'm also using these workarounds and it's annoying because you can accidentally commit them. But if there's a setting, I can put it in some file that's ignored by git, for example in
config/settings/test.local.yml(assuming tests run in test environment; teaspoon tests by default don't but you can run them withRAILS_ENV=test bundle exec teaspoon).