Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ER]: vpc attachments #693

Merged
merged 3 commits into from
Jul 3, 2024
Merged

[ER]: vpc attachments #693

merged 3 commits into from
Jul 3, 2024

Conversation

artem-lifshits
Copy link
Member

What this PR does / why we need it

Implementation of ER vpc attachments.

Acceptance tests

=== RUN   TestVPCAttachmentsLifeCycle
    vpc_attachments_test.go:42: Attempting to create enterprise router
    vpc_attachments_test.go:76: Attempting to create vpc attachemnt
    vpc_attachments_test.go:87: Attempting to delete vpc attachemnt
    vpc_attachments_test.go:51: Attempting to delete enterprise router
--- PASS: TestVPCAttachmentsLifeCycle (114.73s)
PASS

Process finished with the exit code 0

@artem-lifshits artem-lifshits self-assigned this Jul 3, 2024
@artem-lifshits artem-lifshits added the gate Merge PR label Jul 3, 2024
@otc-zuul otc-zuul bot merged commit 516d43b into devel Jul 3, 2024
9 checks passed
@otc-zuul otc-zuul bot deleted the er_vpc_attachments branch July 3, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aloento Aloento Aloento approved these changes

@anton-sidelnikov anton-sidelnikov anton-sidelnikov approved these changes

Assignees

@artem-lifshits artem-lifshits

Labels
gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@artem-lifshits @Aloento @anton-sidelnikov