[build] remove default vendor name #2704
Conversation
bukepo
force-pushed
the
vendor-name-ot
branch
from
2fae691 to
7244739
Compare
bukepo
changed the title
bukepo
force-pushed
the
vendor-name-ot
branch
3 times, most recently
from
5e83900 to
6a5e2d1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2704 +/- ##
===========================================
- Coverage 55.77% 43.30% -12.47%
===========================================
Files 87 108 +21
Lines 6890 13404 +6514
Branches 0 963 +963
===========================================
+ Hits 3843 5805 +1962
- Misses 3047 7291 +4244
- Partials 0 308 +308 ☔ View full report in Codecov by Sentry. |
bukepo
force-pushed
the
vendor-name-ot
branch
3 times, most recently
from
2611459 to
215adbe
Compare
bukepo
changed the title
bukepo
force-pushed
the
vendor-name-ot
branch
7 times, most recently
from
1cde4c5 to
697f551
Compare
| @@ -75,7 +75,8 @@ main() | |||
| ( | |||
| cd "${builddir}" || die "Failed to enter ${builddir}" | |||
|
|
|||
| cmake -GNinja -DCMAKE_EXPORT_COMPILE_COMMANDS=ON "${OTBR_TOP_SRCDIR}" "$@" | |||
| cmake -GNinja -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \ | |||
| -DCMAKE_BUILD_TYPE=Debug "${OTBR_TOP_SRCDIR}" "$@" | |||
There was a problem hiding this comment.
-
Can we add instruction above (around line 47), on how to compile a Debug version, and how to compile a Release version (with the vendor_name and model name as parameter)?
-
Local run to ensure both instructions (Debug and Release) works.
-
if user run command "script/cmake-build -DCMAKE_BUILD_TYPE=Release", the command line parameter "DCMAKE_BUILD_TYPE=Release" will override "-DCMAKE_BUILD_TYPE=Debug" here right?
There was a problem hiding this comment.
if user run command "script/cmake-build -DCMAKE_BUILD_TYPE=Release", the command line parameter "DCMAKE_BUILD_TYPE=Release" will override "-DCMAKE_BUILD_TYPE=Debug" here right?
Yes.
bukepo
force-pushed
the
vendor-name-ot
branch
from
697f551 to
9b2e601
Compare
bukepo
force-pushed
the
vendor-name-ot
branch
from
9b2e601 to
b61e6d7
Compare
This commit forbids using "OpenThreadDebug" as the vendor name in production build. This commit also discourages "BorderRouter" as product name in production build.