Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[trel] require link-local for peer discovered by mDNS #2709

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[trel] require link-local for peer discovered by mDNS #2709

wants to merge 1 commit into from

Conversation

jwhui
Copy link
Member

@jwhui jwhui commented Feb 12, 2025

No description provided.

@jwhui jwhui requested a review from abtink February 12, 2025 18:50
@codecov Codecov
Copy link

codecov bot commented Feb 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 43.65%. Comparing base (2b41187) to head (4c6b7a2).
Report is 957 commits behind head on main.

Files with missing lines Patch % Lines
src/trel_dnssd/trel_dnssd.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2709       +/-   ##
===========================================
- Coverage   55.77%   43.65%   -12.12%     
===========================================
  Files          87      108       +21     
  Lines        6890    13354     +6464     
  Branches        0      953      +953     
===========================================
+ Hits         3843     5830     +1987     
- Misses       3047     7218     +4171     
- Partials        0      306      +306

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

abtink
abtink approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@abtink abtink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. 👍

abtink
abtink approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@abtink abtink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jwhui jwhui marked this pull request as ready for review February 12, 2025 19:36
@jwhui jwhui closed this Feb 12, 2025
@jwhui jwhui reopened this Feb 12, 2025
@jwhui jwhui marked this pull request as draft February 12, 2025 21:12
@abtink abtink mentioned this pull request Feb 12, 2025
Open
@jwhui jwhui marked this pull request as ready for review February 25, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bukepo bukepo bukepo approved these changes

@abtink abtink abtink approved these changes

Assignees
No one assigned
Labels
comp: trel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jwhui @bukepo @abtink