Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pd] bump submodules ot-br-posix, openthread and ot-nrf528xx to include fix for mDNS disruption #102

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yangsong-cnyn
Copy link
Contributor

@yangsong-cnyn yangsong-cnyn commented Jan 9, 2025

openthread f6cee7950d6d4b45ebc9779024b0b456e87159df
ot-br-posix b574b6c2a4ea2ea265f87b908c8ef3f673b27f7f
ot-nrf528xx 6586034ff8377f2d5c87c0f3f8794547c64a4ef2

Include a workaround which disables PD daemon to fix the mDNS disruption

@yangsong-cnyn yangsong-cnyn force-pushed the without_pd_daemon branch 5 times, most recently from 34d9017 to 07c09cd Compare January 14, 2025 05:35
@yangsong-cnyn yangsong-cnyn self-assigned this Jan 21, 2025
@yangsong-cnyn yangsong-cnyn changed the title [pd] Disable PD daemon which caused mDNS disruptions [pd] bump submodules ot-br-posix, openthread and ot-nrf528xx to include fix for mDNS disruption Jan 21, 2025
@yangsong-cnyn yangsong-cnyn marked this pull request as ready for review January 21, 2025 09:12
@@ -13,6 +13,12 @@ FEATURES

CHANGELOG
==========
* 01/21/2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also briefly describe this workaround and the issue it deals with?

@yangsong-cnyn yangsong-cnyn requested a review from jwhui January 21, 2025 09:17
@@ -13,6 +13,13 @@ FEATURES

CHANGELOG
==========
* 01/21/2025
* Disable pd daemon to fix mDNS disruption
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Disable pd daemon to fix mDNS disruption
* Disable PD daemon to fix mDNS disruption

nit

Copy link
Contributor

@superwhd superwhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants