Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cyclopedia improvements #2629

Merged
merged 29 commits into from
Jul 5, 2024

Conversation

elsongabriel
Copy link
Contributor

@elsongabriel elsongabriel commented May 14, 2024

  • Implementing Cyclopedia Features and adjusted some other features such as Blessings, Achievements, Badges, and Titles checks.
  • Improvement on gamestore checks.
  • Set PlayerID of accesses players on on_look script. (usable to know the real player ID).
  • Fixed some things from badge pr.

Adding some features of Cyclopedia in Store Summary Menu.

  • Now we have a "history" and summary of items bought from the Store.
  • We have time of the xp boost.
  • The amount of blessings available.
  • Prey permanent slots (0x, 1x or 2x).
  • Wildcards available.
  • Amount Instant Rewards available.
  • And f you have bought a charm expansion.
  • In Hireling session, the amount of hireling and jobes bought. obs: the hireling outfits is on working in progress (need to check the outfits' ids)
  • Purchased house items list.
  • Show Active preys and marriage in inpect window.

image
image
image

  • In blessing status, we have amount bought from store:
    image

Based of PR #425
thanks @marcosvf132

@elsongabriel elsongabriel marked this pull request as draft May 14, 2024 15:18
@elsongabriel elsongabriel marked this pull request as ready for review May 25, 2024 18:53
@elsongabriel elsongabriel requested review from phacUFPE and dudantas May 30, 2024 23:44
Copy link
Contributor

@phacUFPE phacUFPE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is missing the new files on vcxproj file.

Copy link
Contributor

@phacUFPE phacUFPE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving more comments, because I did not finished in the last review.

src/creatures/players/cyclopedia/player_cyclopedia.cpp Outdated Show resolved Hide resolved
src/server/network/protocol/protocolgame.cpp Outdated Show resolved Hide resolved
src/game/game.cpp Outdated Show resolved Hide resolved
@elsongabriel elsongabriel requested a review from phacUFPE June 23, 2024 18:49
src/creatures/players/cyclopedia/player_cyclopedia.hpp Outdated Show resolved Hide resolved
src/game/game.hpp Outdated Show resolved Hide resolved
@elsongabriel elsongabriel merged commit 3aeb3e7 into opentibiabr:main Jul 5, 2024
29 checks passed
@Chapeleiiro
Copy link
Contributor

3aeb3e7

image

hireling Skills banker is not working, nor is hireling Outfits

@majestyotbr
Copy link
Contributor

3aeb3e7

image

hireling Skills banker is not working, nor is hireling Outfits

The pull request is already merged, you should create a issue instead of comment here.

pasturryx pushed a commit to pasturryx/canary1 that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: PRs Done
Development

Successfully merging this pull request may close these issues.

5 participants