feat: soul pit arena/animus mastery/soul core

[FelipePaluco]

Description

DO NOT BUT IF ITS FREE. PLAYERS CARE ABOUT QUALITY NOT ABOUT EXCLUSIVITY.

This PR aim's to implement SoulPit fighting arena along with Animus Mastery Logic.

Huge thanks and gratitude to @phacUFPE for co-working and thinking together with me on this implementation since the beginning.

Behaviour

Actual

We don't have soulpit mechanics implemented.

Expected

Soul Pit Mechanic implemented.

For further informatin, please take a time to read:
https://tibia.fandom.com/wiki/Soulpit

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Try to drop some Soul Core of fiendish monsters.
• Offer the Soul Core to the Obelisk inside Soulpit entrance
• Fight and see if you animus mastery has increased.
• Check if a bonus % of exp is added when killing the creature

Test Configuration:

• Server Version: 13.40
• Client: 13.40
• Operating System: N/A

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I checked the PR checks reports
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

[paczielny]

There is one small bug on line 3036 in protocolgame.cpp, should be exactly the same what Animus Mastery Bonus is in parseBestiarysendMonsterData now:

What is it supposed to show?

[paczielny]

@FelipePaluco There is a problem with the conditions, whether it's poison, fire, any negative condition in a player causes the game to crash

[markiluk]

What is it supposed to show?

The same value like on Monster details

[markiluk]

@FelipePaluco There is a problem with the conditions, whether it's poison, fire, any negative condition in a player causes the game to crash

Yea, tested as well and tried to debug it, but i am not able to find the problem,
but for sure these changes cause server crash when player receives a condition for example CONDITION_FIRE after stepping on field.

[FelipePaluco]

@markiluk - @paczielny

There is one small bug on line 3036 in protocolgame.cpp, should be exactly the same what Animus Mastery Bonus is in parseBestiarysendMonsterData now:

Solved on b0e4d15

Also the crash problem, i have made some changes on 9dc0f2a

And tested myself walking through some fields, fighting some creatures that apply some conditions, no one crashes my server.

Please, retest everything again with those two new commits.

[FelipePaluco]

@paczielny

the runes are supposed to damage monsters but nothing

This is a different problem I guess. Was reported before on our discord. Open a issue for that as this is not related to the Soul Pit implementation.

Tested here with fields, and when monsters walk into fields, are applying damage accordingly.

[markiluk]

Solved on b0e4d15

Also the crash problem, i have made some changes on 9dc0f2a

And tested myself walking through some fields, fighting some creatures that apply some conditions, no one crashes my server.

Please, retest everything again with those two new commits.

Looks like everything work as expected now ;)
Will test it more for a little bit.

[markiluk]

Nothing important, but monsters have 50% crit chance and I have not seen " (Soulpit Crit)" in logs

[fugu320]

Using an Exalted Core or Soul Prism on a Soul Core from the ground does not consume them, and the Soul Core also remains intact, while an additional new one is sent to the backpack.

[FelipePaluco]

Using an Exalted Core or Soul Prism on a Soul Core from the ground does not consume them, and the Soul Core also remains intact, while an additional new one is sent to the backpack.

@fugu320 - Fixed on 763a806

Please test again!

[fugu320]

Using an Exalted Core or Soul Prism on a Soul Core from the ground does not consume them, and the Soul Core also remains intact, while an additional new one is sent to the backpack.

@fugu320 - Fixed on 763a806

Please test again!

Works perfect.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
6 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[XmasGame]

warning on use 'soul core' in obelisk

warning on use exit from arena in teleport crystal (while the arena is active)

[majestyotbr]

warning on use 'soul core' in obelisk

warning on use exit from arena in teleport crystal (while the arena is active)

It's later to comment here, the pull request is already merged.
Create an issue instead.