fix: player summon lasthit addUnjustifiedKills #3256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudantas
changed the title
|
majestyotbr
approved these changes
Jan 25, 2025
murilo09
approved these changes
Jan 25, 2025
vllworldbuilding
pushed a commit
to vllworldbuilding/canary
that referenced
this pull request
Jan 31, 2025
This addresses an issue where unjustified kills were not being properly activated when the last hit on a player was caused by a summon. The issue occurred because the master of the summon was not being correctly treated as responsible for the kill in certain scenarios. This fix ensures that the master of the summon is correctly identified and unjustified kills are processed appropriately.
lucas-caminha
pushed a commit
to lucas-caminha/canary
that referenced
this pull request
Feb 10, 2025
This addresses an issue where unjustified kills were not being properly activated when the last hit on a player was caused by a summon. The issue occurred because the master of the summon was not being correctly treated as responsible for the kill in certain scenarios. This fix ensures that the master of the summon is correctly identified and unjustified kills are processed appropriately.
Gabirot
pushed a commit
to Gabirot/canary
that referenced
this pull request
Feb 10, 2025
This addresses an issue where unjustified kills were not being properly activated when the last hit on a player was caused by a summon. The issue occurred because the master of the summon was not being correctly treated as responsible for the kill in certain scenarios. This fix ensures that the master of the summon is correctly identified and unjustified kills are processed appropriately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where unjustified kills were not being properly activated when the last hit on a player was caused by a summon. The issue occurred because the master of the summon was not being correctly treated as responsible for the kill in certain scenarios. This fix ensures that the master of the summon is correctly identified and unjustified kills are processed appropriately.
Behaviour
Actual
When a summon delivers the last hit to a player:
Expected
When a summon delivers the last hit to a player:
Type of change
Please delete options that are not relevant.
How Has This Been Tested
The following tests were performed to ensure the correctness of the fix:
Test Configuration:
Checklist