Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: necklace/ring slots exhaustion #3272

Merged
merged 2 commits into from
Jan 26, 2025

Conversation

samuelbfg
Copy link
Contributor

@samuelbfg samuelbfg commented Jan 23, 2025

Description

This PR extends #3165 in the following manner:

I've separated necklace and ring slots in different groups, so the ACTIONS_DELAY_INTERVAL delay flag works on the groups separately.

This means the exhaustion delay continues to be applied on equip items, but considering groups separately. In other words, the players are now able to equip necklaces and rings at the same time, but when trying to equip different necklaces (or rings) they are subject to ACTIONS_DELAY_INTERVAL.

Behaviour

Actual

Players can't equip necklace and ring at the same time.

Expected

Players be able to equip necklace and ring at the same time, but when equiping the same item type, they are subjected to ACTIONS_DELAY_INTERVAL delay flag.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

  • Test A: Equipped necklace/ring at the same time, observing the exhaustion.
  • Test B: Equipped only different necklaces and only different rings, i.e., items in the same slot type, observing the exhaustion.

Test Configuration:

  • Server Version: Latest
  • Client: 13.40
  • Operating System: Linux/Windows

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@majestyotbr majestyotbr merged commit 7b8a234 into opentibiabr:main Jan 26, 2025
24 checks passed
vllworldbuilding pushed a commit to vllworldbuilding/canary that referenced this pull request Jan 31, 2025
This extends opentibiabr#3165 in the following manner:
I've separated necklace and ring slots in different groups, so the `ACTIONS_DELAY_INTERVAL` delay flag works on the groups separately. 
This means the exhaustion delay continues to be applied on equip items, but considering groups separately. In other words, the players are now able to equip necklaces and rings at the same time, but when trying to equip different necklaces (or rings) they are subject to `ACTIONS_DELAY_INTERVAL`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants