Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash in last mount on debug compilation #3284

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

phacUFPE
Copy link
Contributor

Description

When logging in with new characters using debug compilation the server crashes.

Behaviour

Actual

Logs with a new character using debug compilation and it crashes.

Expected

Logs with a new character using debug compilation and it not crashes anymore.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Logs into a new character using debug compilation.

Test Configuration:

  • Server Version: Latest
  • Client: 13.40
  • Operating System: Windows 11

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@majestyotbr majestyotbr merged commit d449359 into main Jan 26, 2025
33 checks passed
@majestyotbr majestyotbr deleted the phacUFPE/fix_crash_mount_debug branch January 26, 2025 16:45
vllworldbuilding pushed a commit to vllworldbuilding/canary that referenced this pull request Jan 31, 2025
lucas-caminha pushed a commit to lucas-caminha/canary that referenced this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants