fix: duplicate player creation on death screen

[dudantas]

Description

This commit fixes a bug where a duplicate player instance was created when a player confirmed the death screen ("ok") and was subsequently kicked for exceeding the maximum packets per second. This bug resulted in two player objects being active simultaneously, leading to unpredictable in-game behavior because the system couldn't determine which instance to interact with.

Behaviour

Actual

When a player confirms the death screen and is kicked for exceeding the max packets per second, a duplicate player instance is created. This leads to two active instances of the same player, causing erratic in-game behavior.

Expected

Upon confirming the death screen, the system should first check if a player with the same name is already online. If so, it should use the existing instance rather than creating a new one, ensuring that only one active instance per player exists.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

To reproduce the bug:

1. Lower the "Max packets per second" value to a very low value (e.g., 7 or 10).
2. Kill your character to trigger the death screen.
3. On the death screen, press "ok" to confirm.
4. Quickly perform an action that sends additional packets (e.g., press "ctrl g", which triggers a client request).
5. When the console displays a message similar to:
   [2025-05-02 00:35:23.770] [thread 26856] [warning] [Connection::parseHeader] - 127.0.0.1 disconnected for exceeding packet per second limit.
   it indicates that the bug has been reproduced.

With this fix applied, the character should not duplicate when following these steps.

• Manual testing was performed following the steps above

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I checked the PR checks reports
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud