Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/broadcast rtmp bitrate #339

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Conversation

SecondeJK
Copy link
Contributor

@SecondeJK SecondeJK commented Aug 17, 2023

This PR adds the ability to choose a maximum Bitrate for new Broadcasts.

Motivation and Context

Evolution of OpenTok SDK

How Has This Been Tested?

New test to pull out the bitrate with expected default value has been added.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #339 (69fce3b) into dev (f1e40f8) will increase coverage by 1.8%.
Report is 12 commits behind head on dev.
The diff coverage is 85.3%.

Files Changed Coverage Δ
src/OpenTok/Util/Validators.php 82.3% <60.0%> (+6.3%) ⬆️
src/OpenTok/Broadcast.php 82.1% <100.0%> (+11.3%) ⬆️
src/OpenTok/OpenTok.php 91.7% <100.0%> (+<0.1%) ⬆️

@SecondeJK SecondeJK changed the base branch from main to dev August 17, 2023 15:39
@SecondeJK SecondeJK merged commit b6e8256 into dev Aug 22, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants