Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/captions api #341

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Feature/captions api #341

merged 3 commits into from
Sep 25, 2023

Conversation

SecondeJK
Copy link
Contributor

@SecondeJK SecondeJK commented Sep 11, 2023 •
edited
Loading

This PR adds functionality for the Captions API

Motivation and Context

Vonage SDK evolution.

How Has This Been Tested?

Tests have been added for two new endpoints

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 11, 2023 •
edited
Loading

Codecov Report

Merging #341 (847edc3) into dev (b6e8256) will decrease coverage by 0.1%.
The diff coverage is 80.0%.

Files Changed Coverage Δ
src/OpenTok/Util/Client.php 74.8% <73.3%> (-0.1%) ⬇️
src/OpenTok/OpenTok.php 92.0% <100.0%> (+0.3%) ⬆️

maxkahan
maxkahan approved these changes Sep 14, 2023
View reviewed changes
Copy link

@maxkahan maxkahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Truly a masterful piece of craftsmanship

@SecondeJK SecondeJK merged commit 5d255be into dev Sep 25, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxkahan maxkahan maxkahan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SecondeJK @maxkahan