Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updates import resolution #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: updates import resolution #3

wants to merge 1 commit into from

Conversation

achrinza
Copy link
Contributor

@achrinza achrinza commented Apr 10, 2020 •
edited
Loading

This PR does 4 things:

  • Updates import resolution to use ES6-style imports and Typescript import/export helpers.
  • Updates internal exports to non-default exports
  • Adds tslib as a devDependency to reduce file size
  • Fixes implicit any types in test files

This PR will help mitigate headaches of...

  • Using the correct import-export syntax by enabling Typescript import handlers.
  • Future refactoring by removing default exports.
  • Making sure the tests compiles

Signed-off-by: Rifa Achrinza [email protected]

@achrinza achrinza force-pushed the feat/update-import-resolution branch from b10c332 to ef40bbf Compare April 10, 2020 06:30
@achrinza
feat: updates import resolution
8cb47fd 
Updates import resolution to use ES6-style imports and Typescript import/export helpers.

Signed-off-by: Rifa Achrinza <[email protected]>

feat: adds `tslib` as a devDependency to reduce overall file size.

Signed-off-by: Rifa Achrinza <[email protected]>

fix: fixes implicit any types in test files.

Signed-off-by: Rifa Achrinza <[email protected]>
@achrinza achrinza force-pushed the feat/update-import-resolution branch from ef40bbf to 8cb47fd Compare April 10, 2020 06:43
@achrinza achrinza marked this pull request as ready for review April 10, 2020 06:48
@achrinza achrinza changed the title [RFC] feat: updates import resolution feat: updates import resolution Apr 16, 2020
@qtangs
Copy link
Contributor

qtangs commented Apr 18, 2020

Thanks @achrinza for all the suggestions, we will need to review and test them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achrinza @qtangs