fix(call-taker): fix mode dropdown for uber + transit

fix #421

lib/components/form/call-taker/mode-dropdown.js

@@ -1,6 +1,8 @@
-import { toSentenceCase } from '@opentripplanner/core-utils/lib/itinerary'
+import coreUtils from '@opentripplanner/core-utils'
 import React, { Component } from 'react'
 
+const { hasTransit, toSentenceCase } = coreUtils.itinerary
+
 /**
  * Dropdown selector for the Call Taker form that allows quick selection of the
  * full set of exclusive modes and access modes + transit. This will also
@@ -43,8 +45,9 @@ export default class ModeDropdown extends Component {
   _onChange = evt => {
     const {value: mode} = evt.target
     const {updateTransitModes} = this.props
-    const selectedOption = this._getModeOptions().filter(o => o.value === mode)
-    const transitIsSelected = mode.indexOf('TRANSIT') !== -1
+    const selectedOption = this._getModeOptions().find(o => o.value === mode)
+    const transitIsSelected = hasTransit(mode)
+    const params = { mode }
     if (transitIsSelected) {
       // Collect transit modes and selected access mode.
       const accessMode = mode === 'TRANSIT' ? 'WALK' : mode.replace('TRANSIT,', '')
@@ -54,17 +57,14 @@ export default class ModeDropdown extends Component {
         ? this.props.selectedTransitModes
         : this.props.modes.transitModes.map(m => m.mode)
       const newModes = [...transitModes, accessMode]
-      if (accessMode.indexOf('CAR') !== -1) newModes.push('WALK')
       updateTransitModes(transitModes)
-      const params = { mode: newModes.join(',') }
+      params.mode = newModes.join(',')
       // Update companies if provided by selected option.
-      if (selectedOption && selectedOption.company) {
-        params.companies = selectedOption.company
+      if (selectedOption?.company) {
+        params.companies = [selectedOption.company]
       }
-      this.props.onChange(params)
-    } else {
-      this.props.onChange({ mode })
     }
+    this.props.onChange(params)
   }
 
   render () {