Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field trip/calltaker tweaks September '23 #1000

Merged
merged 8 commits into from
Oct 3, 2023
Merged

Field trip/calltaker tweaks September '23 #1000

merged 8 commits into from
Oct 3, 2023

Conversation

miles-grant-ibigroup
Copy link
Collaborator

Description:

Field trip and call taker are getting a few tweaks this month!

  • changes to when the yellow flashing happens
  • bug fixes where itin-body doesn't show up when it should
  • new config option to hide headers in the result rows

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

@miles-grant-ibigroup miles-grant-ibigroup self-assigned this Sep 18, 2023
@miles-grant-ibigroup miles-grant-ibigroup marked this pull request as ready for review September 29, 2023 19:46
amy-corson-ibigroup
amy-corson-ibigroup approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1000!!! 🎉 Looks good

binh-dam-ibigroup
binh-dam-ibigroup approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine

@miles-grant-ibigroup miles-grant-ibigroup merged commit cbe67ee into dev Oct 3, 2023
7 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the field-trip-tweaks-sept-23 branch October 3, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amy-corson-ibigroup amy-corson-ibigroup amy-corson-ibigroup approved these changes

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

Assignees

@miles-grant-ibigroup miles-grant-ibigroup

Labels
Call Taker/Field Trip Modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miles-grant-ibigroup @binh-dam-ibigroup @amy-corson-ibigroup