Nearby view #1018
Merged
Nearby view #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Miles Grant <[email protected]>
|
why do some of the stops have a big yellow border? |
|
@daniel-heppner-ibigroup I updated the translations where i could, except for 2 strings in Tagalog that were not provided. |
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
|
@miles-grant-ibigroup I think you broke the tests |
|
Snapshots are updated. @daniel-heppner-ibigroup Not sure why the a11y tests are failing. It works fine locally. Should we just disable the /nearby route for the a11y tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a new Nearby View component which replaces the stop viewer.
PR Checklist:
Before | After |
| 
|
|--------|-------|
|