Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional Lateness Display #1028

Merged
merged 8 commits into from
Oct 26, 2023
Merged

Optional Lateness Display #1028

merged 8 commits into from
Oct 26, 2023

Conversation

miles-grant-ibigroup
Copy link
Collaborator

Description:
Hides the lateness below the striked-through time display

amy-corson-ibigroup
amy-corson-ibigroup requested changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll either need to set this new variable to true on default or switch the config to hideLateness!

example-config.yml Outdated Show resolved Hide resolved
lib/components/viewers/realtime-status-label.tsx Outdated Show resolved Hide resolved
@miles-grant-ibigroup
Copy link
Collaborator Author

Going to add a discussion item about making this change default. I think it should be.

@miles-grant-ibigroup
Copy link
Collaborator Author

Moving forward with off by default as agreed

binh-dam-ibigroup
binh-dam-ibigroup requested changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the new config parameter to lib/util/config-types.ts, and use that type in RealtimeStatusLabel.

lib/components/viewers/realtime-status-label.tsx Outdated Show resolved Hide resolved
binh-dam-ibigroup
binh-dam-ibigroup requested changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The voice over tag for the original time needs to be present.

lib/components/viewers/realtime-status-label.tsx Outdated Show resolved Hide resolved
lib/components/viewers/realtime-status-label.tsx Outdated Show resolved Hide resolved
@amy-corson-ibigroup amy-corson-ibigroup removed their assignment Oct 20, 2023
binh-dam-ibigroup
binh-dam-ibigroup approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the changes

@binh-dam-ibigroup binh-dam-ibigroup removed their assignment Oct 23, 2023
amy-corson-ibigroup
amy-corson-ibigroup approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@miles-grant-ibigroup miles-grant-ibigroup merged commit 66da3d9 into dev Oct 26, 2023
9 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the optional-lateness branch October 26, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amy-corson-ibigroup amy-corson-ibigroup amy-corson-ibigroup approved these changes

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

Assignees

@miles-grant-ibigroup miles-grant-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miles-grant-ibigroup @binh-dam-ibigroup @amy-corson-ibigroup