Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use route color overrides #1029

Merged
merged 16 commits into from
Oct 20, 2023

Conversation

miles-grant-ibigroup
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup commented Oct 11, 2023

Right now, the color overrides are only used in a few places. This PR examples their use into the route viewer, the itinerary body, and the transitive overlay.

Blocked by opentripplanner/otp-ui#670

@miles-grant-ibigroup miles-grant-ibigroup added the WIP Work in progress label Oct 11, 2023
@miles-grant-ibigroup miles-grant-ibigroup self-assigned this Oct 11, 2023
@miles-grant-ibigroup miles-grant-ibigroup added BLOCKED Blocked (waiting on another PR to be merged) and removed WIP Work in progress labels Oct 11, 2023
Copy link
Member

@AdrianaCeric AdrianaCeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@miles-grant-ibigroup miles-grant-ibigroup removed the BLOCKED Blocked (waiting on another PR to be merged) label Oct 19, 2023
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the updated OTP-UI package that this PR was depending on, please?

binh-dam-ibigroup and others added 2 commits October 20, 2023 14:28
Currently translated at 84.5% (437 of 517 strings)

Translation: OTP-react-redux/OTP-RR Main UI
Translate-URL: https://hosted.weblate.org/projects/otp-react-redux/otp-rr-main-ui/zh_Hans/
@miles-grant-ibigroup miles-grant-ibigroup merged commit d35b2cd into dev Oct 20, 2023
9 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the improved-use-of-color-overrides branch October 20, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants