only show routes from current service week #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miles-grant-ibigroup
added
the
BLOCKED
miles-grant-ibigroup
removed
the
BLOCKED
# Conflicts: # package.json # yarn.lock
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
daniel-heppner-ibigroup
requested changes
Oct 3, 2024
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
|
@daniel-heppner-ibigroup to fix the graphql mocks |
daniel-heppner-ibigroup
approved these changes
Oct 25, 2024
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
amy-corson-ibigroup
requested changes
Nov 5, 2024
| @@ -436,11 +438,15 @@ export const fetchNearby = (position, radius) => { | |||
| lon | |||
| code | |||
| gtfsId | |||
| stopRoutes: routes (serviceDates: $currentServiceWeek) { | |||
There was a problem hiding this comment.
I'm getting a "Unknown field argument" graphql error back when I try to view a stop
There was a problem hiding this comment.
This only works on the latest version of OTP. Are you testing against an older OTP version? I'm happy to delay merging this until newer OTP is more widespread
There was a problem hiding this comment.
Oh gotcha, yes the instance of OTP I was using to test looks like the only one of ours this would break! We can discuss that internally
amy-corson-ibigroup
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Makes use of new graphql parameters to limit route and nearby results to current week
blocked waiting for otp-ui to be fixed