Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Puppeteer tests #1287

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Fix Puppeteer tests #1287

merged 2 commits into from
Oct 16, 2024

Conversation

binh-dam-ibigroup
Copy link
Collaborator

Description:

PR adds a Chromium --no-sandbox argument. (Is that required by new OS restrictions?)

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

daniel-heppner-ibigroup
daniel-heppner-ibigroup approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang! Good job debugging. I think we need this on OTP UI as well.

josh-willis-arcadis
josh-willis-arcadis approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@binh-dam-ibigroup binh-dam-ibigroup merged commit 89c4258 into dev Oct 16, 2024
9 checks passed
@binh-dam-ibigroup binh-dam-ibigroup deleted the puppeteer-no-sandbox branch October 16, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh-willis-arcadis josh-willis-arcadis josh-willis-arcadis approved these changes

@daniel-heppner-ibigroup daniel-heppner-ibigroup daniel-heppner-ibigroup approved these changes

Assignees

@binh-dam-ibigroup binh-dam-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@binh-dam-ibigroup @daniel-heppner-ibigroup @josh-willis-arcadis