Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small changes and header css #1300

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Small changes and header css #1300

wants to merge 6 commits into from

Conversation

amy-corson-ibigroup
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup commented Nov 6, 2024 •
edited
Loading

Description:

  • Add margin to loading spinner to avoid clipping.
  • Fix small regression on headsign selector in pattern viewer, to avoid weird spacing on buttons.
  • Clean up navbar css to avoid clipping on all screen sizes.
  • Sort css

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

binh-dam-ibigroup
binh-dam-ibigroup requested changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the cleanup! Could you address the agency logo situation please?

lib/components/app/app.css
@@ -47,36 +47,266 @@
}
}

/* Navbar settings */

.navbar .navbar-header {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of these settings alters the vertical positioning of the agency logo in desktop wide view (See screnshot), that means we need CSS to fix that.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@amy-corson-ibigroup amy-corson-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amy-corson-ibigroup @binh-dam-ibigroup