Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nearby: use stoptime headsigns if applicable #1301

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

miles-grant-ibigroup
Copy link
Collaborator

It seems too easy... Did I miss some edge case?

@miles-grant-ibigroup
Copy link
Collaborator Author

@daniel-heppner-ibigroup do you have any idea why the snapshots are just ever so slightly off? What's going on here?

Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what's happening is the duplicate checking code that follows the line you changed in stop.tsx is no longer matching a duplicate. Double check that and make sure it's okay, or change the duplicate checking code to maybe not use the headsign since it's now not consistent for a pattern?

@miles-grant-ibigroup
Copy link
Collaborator Author

I think what's happening is the duplicate checking code that follows the line you changed in stop.tsx is no longer matching a duplicate. Double check that and make sure it's okay, or change the duplicate checking code to maybe not use the headsign since it's now not consistent for a pattern?

Good catch thanks!

Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snapshot update actually looks really good! At that stop the headsign doesn't show East Green Lake or Roosevelt Station.

@miles-grant-ibigroup miles-grant-ibigroup merged commit c770bbc into dev Nov 14, 2024
9 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the use-stoptime-headsigns branch November 14, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants