-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nearby: use stoptime headsigns if applicable #1301
Conversation
@daniel-heppner-ibigroup do you have any idea why the snapshots are just ever so slightly off? What's going on here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what's happening is the duplicate checking code that follows the line you changed in stop.tsx is no longer matching a duplicate. Double check that and make sure it's okay, or change the duplicate checking code to maybe not use the headsign since it's now not consistent for a pattern?
Good catch thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
snapshot update actually looks really good! At that stop the headsign doesn't show East Green Lake or Roosevelt Station.
It seems too easy... Did I miss some edge case?