Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transit Overlay: Restore missing OTP1 fields #1303

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

miles-grant-ibigroup
Copy link
Collaborator

There was a lastUpdated field that was removed at some point. But now it's back!

Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we maintaining support for OTP1 or are we translating an OTP2 vehicle into something that can be used with our code that still is looking for OTP1 props?

@miles-grant-ibigroup
Copy link
Collaborator Author

Are we maintaining support for OTP1 or are we translating an OTP2 vehicle into something that can be used with our code that still is looking for OTP1 props?

OTP1 transit vehicle overlay uses OTP1 props to maintain OTP1 support and this PR makes sure that that overlay works correctly

Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me

Copy link
Contributor

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@miles-grant-ibigroup miles-grant-ibigroup merged commit 148bf0d into dev Nov 15, 2024
9 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the transit-vehicle-otp2-support branch November 15, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants