-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update context attribute query #1020
Conversation
@nsarka IMO, I think an easier to read and understand approach is to simply define a zero_attr() function that will zero out the attributes prior to going over the mask bit and setting everything as needed. |
Updated |
@nsarka please squash commits and rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I just have to caution that the user must know, either through documentation or otherwise that the attr is in fact cleared and set to only masked values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please update copyrights
e97d448
to
668e0cf
Compare
9726905
to
0fb5ea7
Compare
Copyright updated and commits squashed! |
@nsarka, not related to this PR, but seems like there are some issue with asymmetric memory when used together with pytorch
|
I opened a PR to fix it here: #1026 |
0fb5ea7
to
3c70be9
Compare
From the UCC Backlog:
This PR updates UCC so that all context attribute queries read the mask for each field and then write a value, usually 0. Some of these were missing.
The backlog task mentions updating lib attributes as well, but it seems to me that both CL and TL lib attributes are filled correctly. There are two unused fields not filled--reduction types and sync type--but if the mask has these bits set UCC will error before it reaches the CL or TL (see
ucc_lib_get_attr
).