Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TL/UCP: Check for ucp_memh_pack, if it's not present then disable sliding window and the doca plugin #1032

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

TL/UCP: Check for ucp_memh_pack, if it's not present then disable sliding window and the doca plugin #1032

wants to merge 2 commits into from

Conversation

nsarka
Copy link
Collaborator

@nsarka nsarka commented Oct 8, 2024

Patch for #1031

@nsarka nsarka self-assigned this Oct 8, 2024
@nsarka nsarka requested a review from janjust October 8, 2024 20:47
@nsarka nsarka mentioned this pull request Oct 8, 2024
Open
Sergei-Lebedev
Sergei-Lebedev reviewed Oct 9, 2024
View reviewed changes
Copy link
Contributor

@Sergei-Lebedev Sergei-Lebedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI error is relevant

@janjust
Copy link
Collaborator

janjust commented Oct 9, 2024

@nsarka Something is not quite right

"configure: error: conditional "HAVE_UCP_MEMH_PACK" was never defined.
Usually this means the macro was only invoked conditionally.
Error: Process completed with exit code 1."

janjust
janjust requested changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@janjust janjust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's fix the configure error, otherwise, looks good to me

@nsarka
Copy link
Collaborator Author

nsarka commented Oct 10, 2024

let's fix the configure error, otherwise, looks good to me

I fixed the configure error, but it seems like the Docs pipeline is failing on something else. Missing main.md, which doesn't seem to be relevant to this PR

@nsarka nsarka force-pushed the nsarka/have-memh branch 2 times, most recently from c7ffedd to f240655 Compare October 11, 2024 22:32
@nsarka nsarka requested a review from janjust October 28, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sergei-Lebedev Sergei-Lebedev Sergei-Lebedev left review comments

@samnordmann samnordmann samnordmann approved these changes

@janjust janjust janjust approved these changes

Assignees

@nsarka nsarka

Labels
Ready-for-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nsarka @janjust @Sergei-Lebedev @samnordmann