API: add explicit memory mapping #1037
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nsarka @janjust @Sergei-Lebedev @manjugv May be easier to discuss / track updates to API here. |
|
Can one of the admins verify this patch? |
manjugv
reviewed
Oct 30, 2024
src/ucc/api/ucc.h
Outdated
| * | ||
| * @return Error code as defined by @ref ucc_status_t. | ||
| */ | ||
| ucc_status_t ucc_mem_exchange_post(ucc_mem_map_mem_h *memh); |
There was a problem hiding this comment.
@wfaderhold21 Is there a need to have an explicit call for exchanging memory handles? Why can't one use allgather or other collectives?
There was a problem hiding this comment.
@manjugv Fundamentally, this is an allgather collective. This explicitly has the UCC library perform the operation rather than the User. Is it better to have the User exchange the opaque structure?
There was a problem hiding this comment.
I don't see the value add, and need for explicit collective call.
There was a problem hiding this comment.
@manjugv removed the explicit collective.
manjugv
added
Blocker-for-rel-branch
Ready-for-Review
and removed
WIP - Don't Merge
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds explicit mapping of user-provided memory for various TLs.