Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat : Added support for core set frame list dumping and computed state dumping and loading #1697

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

AdityaSinghDevs
Copy link

Summary

Summary of changes made to NDR transform plugin:

Added functionality to:

  1. Support core set frame list dumping via new CLI options and methods:

    • get_core_set_item_ids()
    • save_core_set_item_ids()
  2. Enable computed state handling for multiple input sources:

    • append_state()
    • compute_state()

Added corresponding CLI arguments:

  • --save_media : Saves Core set frame list in directory
  • --output_dir : Specify directory to save the media files.

These changes allow efficient processing of large video datasets by:

  • Enabling frame list exports for further analysis
  • Supporting state management across multiple sources without RAM constraints

Resolves #140

How to test

Process dataset with multiple video sources using:
python ndr.py --save-core-set core_frames.list --save-deduplicated dedup.list output_dir

Verify outputs:

  1. Check core_frames.list contains selected frame IDs
  2. Verify dedup.list contains deduplicated frame IDs
  3. Confirm output_dir structure matches expected format

Test with large datasets:

  1. Use multiple video sequences >100k frames
  2. Verify memory usage remains stable
  3. Confirm state management works across sources

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file

@AdityaSinghDevs AdityaSinghDevs requested review from a team as code owners January 17, 2025 23:16
@AdityaSinghDevs AdityaSinghDevs requested review from wonjuleee and removed request for a team January 17, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to keep the most significant video frames in dataset
1 participant