Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 to the CI and update Ubuntu #1701

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

gdlg
Copy link

@gdlg gdlg commented Jan 23, 2025

Summary

This PR adds support for Python 3.12 in the project configuration and CI. I have left the min Python version unchanged (3.9).

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

@gdlg gdlg requested review from a team as code owners January 23, 2025 10:57
@gdlg gdlg requested review from wonjuleee and removed request for a team January 23, 2025 10:57
@gdlg gdlg force-pushed the gppayend/py312 branch 4 times, most recently from 7da95f4 to dccae90 Compare January 23, 2025 21:16
@gdlg gdlg marked this pull request as draft January 23, 2025 21:17
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

* Also replace torchtext with tokenizers library.
@gdlg gdlg marked this pull request as ready for review January 25, 2025 01:22
Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.19%. Comparing base (da9e481) to head (ce01fce).
Report is 23 commits behind head on develop.

Files with missing lines Patch % Lines
src/datumaro/plugins/framework_converter.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1701   +/-   ##
========================================
  Coverage    81.19%   81.19%           
========================================
  Files          283      283           
  Lines        33005    33005           
  Branches      5309     5309           
========================================
  Hits         26798    26798           
  Misses        4753     4753           
  Partials      1454     1454           
Flag Coverage Δ
ubuntu-20.04_Python-3.10 ?
ubuntu-24.04_Python-3.12 81.17% <66.66%> (?)
windows-2022_Python-3.10 ?
windows-2022_Python-3.12 81.17% <66.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant