Remove gather metatype from input quantizable #2840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NNCF PT
|
Quantizers are being inserted for gathers which have only one output: |
daniil-lyakhov
force-pushed
the
dl/torch/stop_quantize_gather
branch
from
abc3449 to
1703abe
Compare
|
Fix is not valid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Gather metatype is removed from input quantizable metatypes
Reason for changes
To prevent FQ propagation through gathers (relevant for the ScadeDotProductAttention quantization):
A quantizer starts to quantize all branches of a gather when propagated up through the gather node. This breaks the logic of quantization: some branches should have FP32 precision, and this propagation is ruining it.
Before:
After:
Related tickets
#2766
Tests