[TorchFX] Constant folding #3047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NNCF PT
alexsu52
reviewed
Nov 1, 2024
anzr299
approved these changes
Nov 5, 2024
Co-authored-by: Aamir Nazir <[email protected]>
daniil-lyakhov
commented
Nov 6, 2024
| @@ -802,12 +803,26 @@ def apply_quantization_transformations(model: torch.fx.GraphModule) -> None: | |||
| # to make it easier for algorithms to work | |||
| # with the target graph BatchNorm operations | |||
| # are being fused | |||
| fold_constant_except_qdq(model) | |||
There was a problem hiding this comment.
Can you provide an use case / model to justify this change?
alexsu52
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Constant folding is enabled by default in TorchFX backend
Reason for changes
To align quantizers placement between OV and TorchFX
Related tickets
#2766
Tests