Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mypy] statistics.py factory.py #3187

Merged
merged 4 commits into from
Jan 14, 2025
Merged

[mypy] statistics.py factory.py #3187

merged 4 commits into from
Jan 14, 2025

Conversation

AlexanderDokuchaev
Copy link
Collaborator

@AlexanderDokuchaev AlexanderDokuchaev commented Jan 10, 2025 •
edited
Loading

Changes

  • enable mypy check for nncf/common/statistics.py nncf/common/factory.py
  • Refactor NNCFStatistics with using dataclass

@github-actions github-actions bot added NNCF Common Pull request that updates NNCF Common API Public API-impacting changes labels Jan 10, 2025
@github-actions github-actions bot added the NNCF ONNX Pull requests that updates NNCF ONNX label Jan 10, 2025
@AlexanderDokuchaev AlexanderDokuchaev force-pushed the ad/mypy_statistics branch 3 times, most recently from d2efe95 to 66439a6 Compare January 10, 2025 22:08
@AlexanderDokuchaev AlexanderDokuchaev marked this pull request as ready for review January 10, 2025 22:19
@AlexanderDokuchaev AlexanderDokuchaev requested a review from a team as a code owner January 10, 2025 22:19
@AlexanderDokuchaev AlexanderDokuchaev changed the title statistics [mypy] statistics.py factory.py Jan 10, 2025
@MaximProshin MaximProshin requested a review from kshpv January 13, 2025 10:37
@MaximProshin
Copy link
Collaborator

@kshpv , please review it

kshpv
kshpv reviewed Jan 13, 2025
View reviewed changes
nncf/common/statistics.py Outdated Show resolved Hide resolved
kshpv
kshpv reviewed Jan 13, 2025
View reviewed changes
pyproject.toml Outdated
@@ -96,19 +96,25 @@ files = [
"nncf/api",
"nncf/data",
"nncf/common/collector.py",
# "nncf/common/composite_compression.py",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally it soon should be squeezed to just nncf/common

@AlexanderDokuchaev AlexanderDokuchaev merged commit 2a5ee2a into openvinotoolkit:develop Jan 14, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey-churkin andrey-churkin andrey-churkin approved these changes

@kshpv kshpv kshpv approved these changes

Assignees
No one assigned
Labels
API Public API-impacting changes NNCF Common Pull request that updates NNCF Common NNCF ONNX Pull requests that updates NNCF ONNX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexanderDokuchaev @MaximProshin @kshpv @andrey-churkin