Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up to #2727 #3211

Merged
merged 8 commits into from
Jan 24, 2025
Merged

Follow up to #2727 #3211

merged 8 commits into from
Jan 24, 2025

Conversation

nikita-savelyevv
Copy link
Collaborator

@nikita-savelyevv nikita-savelyevv commented Jan 23, 2025 •
edited
Loading

Changes

Follow up to #2727

  1. Do not use infer_request.results
  2. Replace >= with opset.greater_equal()
  3. Rename ov_numeric.py to openvino_numeric.py

Reason for changes

  1. Improve int4 compression time by up to ~10%
  2. Avoid warning: DeprecationWarning: greater_equal is deprecated and will be removed in version 2025.3. Use ops.greater_equal instead
  3. Fix onnx install test

Related tickets

139047

Tests

@github-actions github-actions bot added the NNCF OpenVINO Pull requests that updates NNCF OpenVINO label Jan 23, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation NNCF PTQ Pull requests that updates NNCF PTQ labels Jan 24, 2025
@nikita-savelyevv nikita-savelyevv marked this pull request as ready for review January 24, 2025 10:38
@nikita-savelyevv nikita-savelyevv requested a review from a team as a code owner January 24, 2025 10:38
alexsu52
alexsu52 approved these changes Jan 24, 2025
View reviewed changes
nncf/openvino/optimized_functions/models.py
inputs, share_inputs=ov_model_params.share_inputs, share_outputs=ov_model_params.share_outputs
)
outputs = [infer_request.get_output_tensor(i) for i in range(len(infer_request.results))]
outputs = [infer_request.get_output_tensor(i) for i in range(len(outputs))]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code will allow you to not create the last list:

    if ov_model_params.return_ov_tensors:
        outputs = [Tensor(infer_request.get_output_tensor(i)) for i in range(len(outputs))]
    else:
        outputs = [Tensor(outputs[i]) for i in range(len(outputs))]

@alexsu52 alexsu52 merged commit 1067d49 into openvinotoolkit:develop Jan 24, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderDokuchaev AlexanderDokuchaev AlexanderDokuchaev approved these changes

@alexsu52 alexsu52 alexsu52 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF PTQ Pull requests that updates NNCF PTQ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikita-savelyevv @alexsu52 @AlexanderDokuchaev