[TRANSFROMATIONS] Add support for 'inputs_embeds' input in SDPAToPA #27158
+197
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for 'input_embeds' input in SDPAToPA transformation. The input is used in VLM instead of 'input_ids' in text-only models. The changes enable support of the SDPAToPA transformation for the following models: * llava-hf/llava-1.5-7b-hf * llava-hf/llava-v1.6-mistral-7b-hf * llava-hf/llava-v1.6-vicuna-7b-hf * llava-hf/llama3-llava-next-8b-hf * openbmb/MiniCPM-V-2_6 Signed-off-by: Andrii Staikov <[email protected]> - Tickets: * CVS-152288
CuriousPanCake
changed the title
rkazants
reviewed
Oct 21, 2024
|
should we continue with it? |
please mention it in the PR description |
itikhono
approved these changes
Nov 13, 2024
CuriousPanCake
force-pushed
the
CVS-152288
branch
from
3815c3e
to
a1eef49
Compare
github-actions
bot
added
category: CI
github-actions
bot
removed
category: CI
praasz
reviewed
Nov 14, 2024
Comment on lines
61
to
67
| if (auto casted_param = std::dynamic_pointer_cast<v0::Parameter>(param.get_node_shared_ptr())) { | ||
| return casted_param; | ||
| } else { | ||
| OPENVINO_THROW("The model is in the inconsistent state. Found input '", | ||
| name, | ||
| "', but couldn't cast it to v0::Parameter."); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (auto casted_param = std::dynamic_pointer_cast<v0::Parameter>(param.get_node_shared_ptr())) { | |
| return casted_param; | |
| } else { | |
| OPENVINO_THROW("The model is in the inconsistent state. Found input '", | |
| name, | |
| "', but couldn't cast it to v0::Parameter."); | |
| } | |
| auto casted_param = ov::as_type_ptr<v0::Paramter>(param.get_node_shared_ptr())); | |
| OPENVINO_ASSERT(casted_param , "The model is in the inconsistent state. Input is not paramter: ", casted_param); | |
| return casted_param; |
Use ov::as_type_ptr<> instead of std::dynamic_pointer_cast for operators.
| const std::string& name) -> std::shared_ptr<v0::Parameter> { | ||
| for (auto& param : model->inputs()) { | ||
| const auto& names = param.get_names(); | ||
| if (names.find(name) != names.end()) { |
There was a problem hiding this comment.
Suggested change
| if (names.find(name) != names.end()) { | |
| if (names.count(name)) { |
| @@ -53,8 +53,28 @@ bool ov::pass::SDPAToPagedAttention::run_on_model(const std::shared_ptr<ov::Mode | |||
|
|
|||
| auto sliding_window = v0::Constant::create(element::i32, Shape{}, {0}); // sliding_window | |||
|
|
|||
| auto has_parameter = [=](const std::shared_ptr<ov::Model>& model, | |||
| const std::string& name) -> std::shared_ptr<v0::Parameter> { | |||
| for (auto& param : model->inputs()) { | |||
There was a problem hiding this comment.
Suggested change
| for (auto& param : model->inputs()) { | |
| for (const auto& param : model->inputs()) { |
| @@ -53,8 +53,28 @@ bool ov::pass::SDPAToPagedAttention::run_on_model(const std::shared_ptr<ov::Mode | |||
|
|
|||
| auto sliding_window = v0::Constant::create(element::i32, Shape{}, {0}); // sliding_window | |||
|
|
|||
| auto has_parameter = [=](const std::shared_ptr<ov::Model>& model, | |||
There was a problem hiding this comment.
Consider rename as it not returns bool value.
There was a problem hiding this comment.
Yeah, I also don't like the name 100%, but I'd leave it as it is as it's used in cases when want to do something if a model has a parameter.
|
I've disabled a few failing models due to the latest version of transformers (4.46.2). The updated version of the package adds regression to the models, but enables the nanollava model. The regression will be fixed in 157416 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[TRANSFROMATIONS] Add support for 'inputs_embeds' input in SDPAToPA
Add support for 'input_embeds' input in SDPAToPA transformation.
The input is used in VLM instead of 'input_ids' in text-only models.
The changes enable support of the SDPAToPA transformation for the following models:
CVS-156956
Signed-off-by: Andrii Staikov [email protected]