Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] [GHA] Introduce additional Python (3.9-3.12) API tests on Windows #27304
base: master
Are you sure you want to change the base?
[CI] [GHA] Introduce additional Python (3.9-3.12) API tests on Windows #27304
Changes from 25 commits
2e60f85
462a17c
95febdf
298d251
85bbeea
7f81439
6ec23b0
ff48a8c
fc4e692
836ccad
c96669a
cfdb4d2
94e0349
ef39455
797a22c
16c6ea0
1938717
ec3be60
ebcefcb
89e588a
a570fe9
db3eb0b
88e82c5
e62830d
4fefe20
fd949d3
a61ff4e
f5bc263
d208cac
8ac65d4
64b811c
320187d
fa5e1af
0fa0034
895af7a
4afb060
8a39a78
1a92d95
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest a bit different approach to find and install wheels, to simplify support in future:
For example how to call this action:
# Install Python benchmark_app by installing openvino-*.whl
- name: Install OpenVINO Python wheels
uses: ./openvino/.github/actions/install_ov_wheels
with:
wheels-dir-path: ${{ env.INSTALL_WHEELS_DIR }}
install-wheels: |
- openvino[extra]
- openvino-dev
- openvino-tokenizers
- openvino-genai
And inside the action we could use the following installation aproach:
pip install openvino[extra] openvino-dev openvino-tokenizers --find-links ${{ env.INSTALL_WHEELS_DIR }} --no-index --no-cache
@ilya-lavrenov , @akladiev what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip will find the suitable weel by himself and do not pickup it from PyPI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a problem with this approach: since the idea is to use
--no-index
so that pip does not try to install any local wheels from PyPI instead, it cannot install the dependencies because it is forbidden from trying to access PyPI like in https://github.com/openvinotoolkit/openvino/actions/runs/11794716928/job/32855012693#step:7:43. The wheels have many dependencies that are hosted on the package index hence we cannot restrict the pip from accessing the index.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, but the 1st comment is still actual, I think it is better to make action more universal (just provide the wheel pattern names as argument)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, to make sure that a local wheel is installed, internally we pass the expected package version like this
pip install openvino-dev==2025.0.0.dev20241113 --find-links...
. So there is no need for --no-index. Package version is saved to our manifest file before build starts (field wheel_product_version).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we should proceed with the current approach: using the
openvino openvino_tokenizers ...
as the input and iterating over the given wheel names for installation.Additionally, the
openvino_tokenizers
wheel has a different version for some reason:so we would not be able to use it for local installation. Also, it would be rather cumbersome to pass the version from the
build
job to other jobs in which the wheels are used.