Support for model reshape in protopipe #27398
Open
+53
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeptimiuIoachimNeagaIntel
requested review from
kblaszczak-intel
and removed request for
a team
github-actions
bot
added
category: docs
src/plugins/intel_npu/tools/protopipe/src/simulation/ov_layers_reader.cpp
Outdated
Show resolved
Hide resolved
src/plugins/intel_npu/tools/protopipe/src/simulation/ov_layers_reader.cpp
Outdated
Show resolved
Hide resolved
src/plugins/intel_npu/tools/protopipe/src/simulation/ov_layers_reader.cpp
Outdated
Show resolved
Hide resolved
SeptimiuIoachimNeagaIntel
force-pushed
the
EISW-142643_dynamic_shape
branch
from
03af6b0
to
b775841
Compare
src/plugins/intel_npu/tools/protopipe/src/simulation/layers_reader.cpp
Outdated
Show resolved
Hide resolved
src/plugins/intel_npu/tools/protopipe/src/simulation/layers_reader.cpp
Outdated
Show resolved
Hide resolved
src/plugins/intel_npu/tools/protopipe/src/simulation/ov_layers_reader.cpp
Outdated
Show resolved
Hide resolved
src/plugins/intel_npu/tools/protopipe/src/simulation/ov_layers_reader.cpp
Outdated
Show resolved
Hide resolved
src/plugins/intel_npu/tools/protopipe/src/simulation/layers_reader.cpp
Outdated
Show resolved
Hide resolved
| return getOVReader().readLayers(ov, true /* use_results_names */); | ||
| auto inOutLayers = getOVReader().readLayers(ov, true /* use_results_names */); | ||
| adjustDynamicDims(inOutLayers.in_layers); | ||
| adjustDynamicDims(inOutLayers.out_layers); |
There was a problem hiding this comment.
It would be strange to see data will be provided as input if you call this function on output layers
There was a problem hiding this comment.
Function no longer called for output layers. I was never sure it was required
There was a problem hiding this comment.
But seems it does. If output layer has -1 it will be impossible to allocate memory for this buffer
There was a problem hiding this comment.
With or without updating output layer I saw no difference in the result.
There was a problem hiding this comment.
Simply because your model don't have dynamic shapes for outputs.
|
Please also update description of this PR to reflect what changes have been made |
TolyaTalamanov
requested changes
Nov 15, 2024
src/plugins/intel_npu/tools/protopipe/src/simulation/layers_reader.cpp
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Support for model reshape in protopipe
Added new OpenVINO parameter in config.yaml
-reshapeable to reshape input layers.For ONNX models dynamic dimensions are set to
1. This is consistent with the behavior of onnxruntime_perf_test.