[CPU] sns f16_mha_on_avx512_core_amx_f16_target #27514
Open
+106
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@a-sidorova @v-Golubev @IvanNovoselov , Could you please review? Thanks! |
a-sidorova
reviewed
Nov 14, 2024
src/plugins/intel_cpu/tests/functional/shared_tests_instances/snippets/mha.cpp
Outdated
Show resolved
Hide resolved
a-sidorova
reviewed
Nov 15, 2024
Comment on lines
125
to
+130
| if (dnnl::impl::cpu::x64::mayiuse(dnnl::impl::cpu::x64::avx512_core_bf16) && ov::is_type<snippets::op::Brgemm>(op)) { | ||
| return {{element::bf16, element::bf16}}; | ||
| } | ||
| if (dnnl::impl::cpu::x64::mayiuse(dnnl::impl::cpu::x64::avx512_core_amx_fp16) && ov::is_type<snippets::op::Brgemm>(op)) { | ||
| return {{element::f16, element::f16}}; | ||
| } |
There was a problem hiding this comment.
I just think that the function body should be so:
std::set<std::vector<ov::element::Type>> types;
if (ov::is_type<snippets::op::Brgemm>(op)) {
if (dnnl::impl::cpu::x64::mayiuse(dnnl::impl::cpu::x64::avx512_core_amx_fp16))
types.insert({element::f16, element::f16});
if (dnnl::impl::cpu::x64::avx512_core_bf16)
types.insert({element::bf16, element::bf16});
}
return types;
Also tell me please, if you have verified this pass and it works?
| MHA, | ||
| ::testing::Combine(::testing::ValuesIn(transposedShape_4D(false)), | ||
| ::testing::ValuesIn(precision_f32(4)), | ||
| ::testing::ValuesIn(mha_infer_precision_fp16_if_supported()), |
There was a problem hiding this comment.
Suggested change
| ::testing::ValuesIn(mha_infer_precision_fp16_if_supported()), | |
| ::testing::ValuesIn(ov::element::f16), |
And just skip test in skip_test_config if there is no ISA amx_fp16 on the platform as it's implemented for bf16
There was a problem hiding this comment.
Could you tell me please if you launched these added tests on GNR or using SDE?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: