[PyAPI] Fix string truncation when special \u0000 is inside string #28373
+60
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
align py::array conversion with numpy logic Signed-off-by: Raasz, Pawel <[email protected]>
Signed-off-by: Raasz, Pawel <[email protected]>
Signed-off-by: Raasz, Pawel <[email protected]>
praasz
changed the title
Signed-off-by: Raasz, Pawel <[email protected]>
akuporos
reviewed
Jan 10, 2025
| @@ -118,15 +118,29 @@ const TensorIndexMap cast_to_tensor_index_map(const py::dict& inputs) { | |||
|
|
|||
| namespace string_helpers { | |||
|
|
|||
| namespace { | |||
| auto find_last_not_null(const std::string& str) { | |||
There was a problem hiding this comment.
could you please specify a return type here for readability?
There was a problem hiding this comment.
It was done intentionally to auto deduce return type. As local scope helper is easier to modify it. The IDE's hint or compiler will show detailed type if there will be wrong use.
Signed-off-by: Raasz, Pawel <[email protected]>
Signed-off-by: Raasz, Pawel <[email protected]>
Signed-off-by: Raasz, Pawel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
py::arrayov::Tensornumpyformat when there are trailing null characters. The strides will be not same for OV representation. This is not real (very uncommon) case of use string with many trailing null characters.Related PRs:
Tickets: