[CPU] Fixed accuracy of compressed matmul with scalar scale #28431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: IE Tests
v-Golubev
approved these changes
Jan 14, 2025
| @@ -74,6 +75,7 @@ INSTANTIATE_TEST_SUITE_P(smoke_MatMulCompressedWeights_corner_cases, | |||
| ::testing::ValuesIn(decompression_precisions_corner_cases), | |||
| ::testing::Values(ov::element::undefined), | |||
| ::testing::ValuesIn(transpose_weights), | |||
| ::testing::Values(DecompressionType::full), | |||
There was a problem hiding this comment.
Maybe we can add DecompressionType::scalar multiply instances for ARM? If ARM has the same issue as X64, the failed tests will be a good indication: we could skip them for now with the corresponding comment (e.g. with ticket number)
There was a problem hiding this comment.
We are using oneDNN ref mamtul to cover compression on ARM now. So the fix doesn't affect ARM behavior.
However the idea the cover some corner cases for ARM sounds reasonable. Will follow-up in separate PR.
...ntel_cpu/tests/functional/custom/subgraph_tests/src/classes/matmul_weights_decompression.cpp
Show resolved
Hide resolved
...ns/intel_cpu/tests/functional/custom/subgraph_tests/src/x64/matmul_weights_decompression.cpp
Show resolved
Hide resolved
MirceaDan99
pushed a commit
to MirceaDan99/openvino
that referenced
this pull request
Jan 22, 2025
…toolkit#28431) ### Details: - This PR fixes accuracy of compressed Matmuls with scalar scale - The issue was on micro-kernel level: incorrect offset during scales load oneDNN PR: openvinotoolkit/oneDNN#270 ### Tickets: - [CVS-143420](https://jira.devtools.intel.com/browse/CVS-143420)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
oneDNN PR: openvinotoolkit/oneDNN#270
Tickets: