Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose request object certificate in authorization request #64

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

Dindexx
Copy link
Contributor

@Dindexx Dindexx commented Mar 12, 2024

Short description of what this resolves:

Exposes the certificate of the request object so that the framework consumer can view it.

@Dindexx Dindexx requested a review from JoTiTu March 12, 2024 13:51
@Dindexx Dindexx self-assigned this Mar 12, 2024
Copy link
Contributor

@JoTiTu JoTiTu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from one import

@@ -10,6 +10,7 @@
using static Hyperledger.Aries.Features.OpenId4Vc.Vp.Models.AuthorizationRequest;
using static Newtonsoft.Json.Linq.JArray;
using static System.Convert;
using static Hyperledger.Aries.Features.OpenId4Vc.Vp.Models.ClientIdScheme.ClientIdSchemeValue;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused

@JoTiTu JoTiTu self-requested a review March 21, 2024 12:10
@Dindexx Dindexx merged commit 2355300 into main Mar 21, 2024
3 checks passed
@JoTiTu JoTiTu deleted the expose-request-object-certificate branch May 6, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants